davsclaus opened a new pull request, #26940:
URL: https://github.com/apache/camel/pull/26940

   Fixes [CAMEL-25057](https://issues.apache.org/jira/browse/CAMEL-25057): bugs 
in the dev consoles found in a deep review. Tests in `ConsoleEdgeCasesTest` and 
`ManagedConsoleEdgeCasesTest` fail without the fixes (except 5, see below).
   
   1. **The consumer console never shows the details of a scheduled poll 
consumer** (scheduled, polling, delay, backoff, ...). It tested whether the 
`ManagedCamelContext` was a `ManagedSchedulePollConsumerMBean`; and the managed 
consumer is a JMX proxy of `ManagedConsumerMBean` only, so it is not an 
instance of the scheduled poll interface either. It now asks for the scheduled 
poll proxy when the route's consumer is a `ScheduledPollConsumer`.
   2. **The processor console with `limit` returns one processor too many in 
JSON** (the text output was right).
   3. **The trace console dumps with `dump=false`**: any value dumped the 
traced messages. The CLI, TUI and connector all pass `dump=true`.
   4. **The browse console with `freshSize=true` ignores `limit`** and dumps 
every message of the endpoint.
   5. **The processor console fails with `NullPointerException` when 
camel-management is not in use** (the other management-driven consoles check 
for it). No test: with camel-management now on the test classpath the case 
cannot happen in this module.
   
   camel-console gets **camel-management as a test dependency** (test scope 
only), so the consoles driven by the managed MBeans can be tested; their 
existing tests note they could not.
   
   **Not changed (for a later look)**
   - The JFR memory leak console applies its group limit when parsing the 
recording and not in `query`, keeping the first groups seen rather than the 
largest.
   - The inflight console filter is an exact, case-sensitive match of the 
originating route, while other consoles use wildcards.
   - The processor detail console overwrites repeated child options (the 
exceptions of `doCatch`) and drops attribute-only expressions (`tokenize`).
   - The sql query console `update-row` converts string values to numbers or 
booleans (`"007"` is stored as `7`).
   - `idleSince` is documented as epoch time but is a duration.
   
   The whole `camel-console` test suite passes.
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to