allthingssecurity commented on PR #26788: URL: https://github.com/apache/camel/pull/26788#issuecomment-5861537914
@davsclaus thanks. I rebased on main after CAMEL-24991 and kept its `forceCompletion()`/`forceDiscarding()` structure. The earlier force-discard unmark calls were dropped in the rebase, and the review changes are in a new commit on top, 4ef51a39e: - `forceDiscarding()` clears the completing mark (`unmarkCompleting(answer.getExchangeId())`) in a `finally` around `discard(key, answer)`. The mark is cleared after the confirm, and also when the confirm fails, so the recover task can still pick the group up. The comment now says the exchange is discarded instead of passed to `onSubmitCompletion`. - New `AggregateRecoverInProgressTest.testForceDiscardingNotConfirmedIsRecovered`: a group is force discarded, its confirm fails, and the recover task must still recover it rather than treat it as being completed. - `AggregatePreCompleteLostGroupTest` uses the static `await()` import. Its latch helper is renamed to `awaitLatch`, since a local `await` method would shadow the import. Tests: camel-core `*Aggregat*` ran 252 tests with 0 failures and 5 skipped. Negative controls: without the new unmark, the new test fails (0 messages recovered instead of 1). With main's `AggregateProcessor`, the 3 race tests in `AggregateRecoverInProgressTest` fail (recover called once instead of 0 times). _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
