oscerd commented on code in PR #26962:
URL: https://github.com/apache/camel/pull/26962#discussion_r4122565435
##########
core/camel-util/src/main/java/org/apache/camel/util/URISupport.java:
##########
@@ -106,21 +109,104 @@ public static synchronized void
addSanitizeKeywords(String keywords) {
* @param uri The uri to sanitize.
* @return Returns null if the uri is null, otherwise the URI with the
passphrase, password or secretKey
* sanitized.
- * @see #ALL_SECRETS and #USERINFO_PASSWORD for the matched pattern
+ * @see SensitiveUtils#maskUserInfoCredentials(String, String) for
how the userinfo password is found
Review Comment:
Right, thanks. `maskUserInfoCredentials` is main-only (CAMEL-24256), and
only the package-private helper was ported here. Applied your suggestion in
7f38b38: the `@see` now points at `SensitiveUtils#maskUserInfo(String, String,
boolean)`, which exists on `camel-4.18.x`. Nothing else on the branch
referenced `maskUserInfoCredentials`. camel-util's `URISupportTest` and
`SensitiveUtilsTest` pass, and so does the 4.18.x full reactor (`-DskipTests`).
_Claude Code on behalf of @oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
