oscerd commented on PR #26734: URL: https://github.com/apache/camel/pull/26734#issuecomment-5873948228
Thanks @davsclaus and the review agent — all review points are now addressed: - **Named error for a bad timeout** — a parse failure throws `IllegalArgumentException` naming the property and quoting the value (`aef30ee3`), pinned by a test. - **Test server busy-spin** — replaced with a blocking `transferTo(nullOutputStream())` (`aef30ee3`). - **`stopped` reset race** — reset before `acceptor.start()` (`cf32ce93`), with a comment on why the order is not load-bearing under PER_METHOD (`09406232`). - **Charset constant** — `StandardCharsets.US_ASCII` (`aef30ee3`). - **Descriptive test method names** — adopted as suggested. - **Drop `public` from the new test class/methods** — done (`67115e6`). Note: I re-checked and this specific rule is not actually in `CLAUDE.md`; I applied it anyway as a convention the committers ask for on new tests. `HttpResourceTimeoutTest` passes (5/5) and the module builds. Re-requesting review. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
