davsclaus commented on PR #27013:
URL: https://github.com/apache/camel/pull/27013#issuecomment-5874971722
Thanks for the backport. It is missing one of the three files from #26855.
On main, the fix also wraps the metric assertions of `MessageHistoryTest` in
`await().untilAsserted(...)`:
```java
// Metric recording via nodeProcessingDone() happens asynchronously on seda
threads,
// so all metric assertions need to be wrapped in await() to avoid a race
with mock receipt.
await().atMost(5, TimeUnit.SECONDS).untilAsserted(() -> {
// there should be 3 names
assertEquals(3,
getAllPointData(DEFAULT_CAMEL_MESSAGE_HISTORY_METER_NAME).size());
assertEquals(count / 2, getPointData("route1", "foo").getCount());
assertEquals(count / 2, getPointData("route2", "bar").getCount());
assertEquals(count / 2, getPointData("route2", "baz").getCount());
});
```
On `camel-4.22.x` that test still asserts right after
`MockEndpoint.assertIsSatisfied(context)`, which is the same race that made
`MessageHistoryExceptionRouteTest` fail on #26895. Could you add it, so the
backport matches #26855?
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
