oscerd commented on issue #2970: URL: https://github.com/apache/camel-kamelets/issues/2970#issuecomment-5888135594
**Decision: option 1 — no default, force an explicit choice.** PR: #3069. `saslAuthType` is now in `required` and carries no default. `NONE` stays available and behaves exactly as before; it just has to be asked for rather than inherited. **One correction to this issue's text**, since it shaped the options: there is no plain `kafka-not-secured-source` or `-sink`. All six `not-secured` Kamelets are apicurio-registry variants, and they do not default `saslAuthType` — they omit it entirely and say "on an insecure broker" in the description. So the convention is real, but there was no sibling to point users at, which is part of why option 3 (split) would have been more work than it first looked. **Verified the break has the right shape.** On Camel 4.22.0 with `camel run` against the working tree, omitting the property now fails at route-template creation, by name: ``` IllegalArgumentException: Route template kafka-source the following mandatory parameters must be provided: saslAuthType ``` and `saslAuthType: NONE` passes validation and reaches the broker connection unchanged. A named startup failure with an obvious fix, rather than a silent behaviour change. **Two in-tree consumers relied on the default** and are updated in the PR: the Citrus itest route (which would have broken — `KafkaIT` is green with it set) and the doc partial, which stated the default in two places. Both pipe templates already passed it explicitly. ## Two follow-ups I have not taken unilaterally 1. **`kafka-sink`, `kafka-batch-source` and `ceph-event-based-source` have the identical shape** — `default: NONE`, absent from `required`. This issue covers `kafka-source`, so I scoped the PR to it rather than sweeping them in. Extending is a one-line change per Kamelet plus whatever in-tree consumers rely on the default; say which you prefer and I will either widen #3069 or file a sibling issue. 2. **This change warrants an upgrade-guide note, and this repository has no upgrade guide.** The right home is `apache/camel`'s `camel-4x-upgrade-guide-4_23.adoc`, which already carries Kamelet entries. That is a separate cross-repo PR — happy to open it. --- _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
