carlesarnal commented on PR #24844: URL: https://github.com/apache/camel/pull/24844#issuecomment-5888517548
Thanks @davsclaus. All three are addressed in 9ffb47280a0, on top of the rebased branch. 1. **Failed versions.** After processing, the consumer now checks `exchange.getException()`. If it is set, the consumer reports it through `getExceptionHandler()`, stops the poll and leaves the watermark where it was, so the version is retried next time. There is a new route-based test using the default error handler: version 1 fails once, then versions 1 and 2 arrive in order. 2. **Pagination.** The consumer requests versions ordered by globalId, newest first, 100 per page, and stops at the watermark. It deduplicates by globalId in case a new version shifts the pages between requests. `listVersions` now follows every page. The tests use a fake that behaves like the registry, including its default page of 20. 3. **Vert.x.** There is now a single Vert.x instance per component. It is created on first use and closed when the component stops. It can also be supplied through the new `vertx` option, or autowired from the registry, in which case the component leaves it open. From the minor points: tests now use `camel-test-junit6`, and the test infra is registered in `camel-test-infra-all` (dependency, jandex, metadata and the catalog copy). I left `getServiceProtocol()` as `"http"`, as you suggested. `testCompatibility` also sets the result header now, as the bot review asked. The docs and generated catalog/DSL files are updated. Locally, 42 unit tests and 8 integration tests pass. _AI-assisted response prepared with OpenCode on behalf of @carlesarnal._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
