oscerd opened a new pull request, #27075:
URL: https://github.com/apache/camel/pull/27075

   Backport of #26733 (`2871cbdfc8e9`) to `camel-4.22.x`.
   
   ## Why this was not automatic
   
   The PR carried a `port/camel-4.22.x` label, which does **not** trigger 
anything, so the change never
   reached this branch — while the matching entry in 
`camel-4x-upgrade-guide-4_22.adoc` on `main`, under
   *Upgrading from 4.22.1 to 4.22.2*, already tells users the behaviour changed 
here. This closes that gap;
   without it the guide documents something 4.22.2 would not ship.
   
   ## What it fixes
   
   `DebeziumEngine.create(Connect.class)` builds an `AsyncEmbeddedEngine`, 
whose `run()` catches `Throwable`
   itself and reports through the `CompletionCallback` without ever rethrowing. 
The consumer registered no
   such callback, so its own `catch` around `dbzEngine.run()` was dead code and 
nothing in Camel learned the
   engine had died — a connector that cannot start left the route **started and 
the health check UP** while
   delivering nothing. Stopping such a route also threw, because `close()` 
rejects an already-stopped engine,
   which skipped the thread pool shutdown.
   
   ## Deviations from the original
   
   Only one, and it is the project convention rather than a code change: the 
two upgrade-guide files are
   **not** included, since the per-release guides for every line live on 
`main`. Everything else — the
   consumer, the new `DebeziumConsumerHealthCheck`, both tests and the six 
component docs with their catalog
   mirrors — is the cherry-pick verbatim.
   
   ## Verification
   
   `camel-debezium` on this branch already uses `camel-test-junit6`, like 
`main`, so no test adaptation was
   needed. Module suite green: **18 tests**, including 
`DebeziumConsumerEngineFailureTest`, which drives a
   connector that cannot read its offset store and asserts the failure reaches 
the exception handler and the
   health check reports `DOWN`.
   
   Worth noting the branch pins Debezium **3.6.1.Final** against 
**3.6.3.Final** on `main`; the test passing
   here is what confirms the engine's callback behaviour is the same on that 
version.
   
   _Claude Code on behalf of oscerd_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to