gnodet commented on PR #26845: URL: https://github.com/apache/camel/pull/26845#issuecomment-5889580762
@apupier Addressing your remaining review points: 1. **Camel Quarkus ticket** — created: https://github.com/apache/camel-quarkus/issues/9252. It documents the reflection metadata needed for both HikariCP and Agroal in native mode. 2. **Agroal flush resolution** — addressed in 673fa2b: now resolves `flush(FlushMode)` through the public `AgroalDataSource` interface (`Class.forName` + `isInstance`) rather than `ds.getClass().getMethods()`. This is more robust with proxies and wrapper classes, as davsclaus suggested. 3. **Tests closer to real use case**: the current tests use real HikariCP and Agroal pools against h2 and verify that eviction actually replaces physical connections (via `unwrap(Connection.class)` + `assertNotSame`). A full credential rotation integration test (start pool with password A → rotate to password B → verify new connections use B) would require either a PostgreSQL container in CI or a custom `DataSource` that reads credentials dynamically — both of which would significantly increase the test surface and CI time. This could be a follow-up, similar to the Agroal support which was also added incrementally. The current tests cover the reflection path and the eviction behavior, which is the core of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
