davsclaus commented on code in PR #26988:
URL: https://github.com/apache/camel/pull/26988#discussion_r4132778909


##########
components/camel-kafka/pom.xml:
##########
@@ -152,6 +152,11 @@
             <version>${mockito-version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel</groupId>
+            <artifactId>camel-catalog</artifactId>

Review Comment:
   This creates a cycle: camel-kafka → camel-catalog (test) → 
camel-allcomponents (pom, test) → camel-kafka. Reactor ordering ignores 
exclusions, so the full build fails with a cyclic reference, and no other 
component depends on camel-catalog. Please drop this dependency and validate 
through the runtime catalog instead, e.g. 
`context.getCamelContextExtension().getContextPlugin(RuntimeCamelCatalog.class).validateEndpointProperties(...)`
 (camel-core-catalog, reads the component's own kafka.json), or go back to the 
simpler test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to