gnodet-bot commented on code in PR #27195:
URL: https://github.com/apache/camel/pull/27195#discussion_r4154195891
##########
components/camel-openfga/src/main/java/org/apache/camel/component/openfga/OpenFgaEndpoint.java:
##########
@@ -85,6 +90,31 @@ protected void doStart() throws Exception {
* it - a missing {@code relation} on a check would otherwise surface as a
deny, which looks exactly like a policy
* decision and is a thoroughly misleading thing to debug.
*/
Review Comment:
💡 The `parseStartTime()` insertion here strands the existing Javadoc for
`validateOperationOptions()`. In the original file, the comment block ending at
the `*/` above documented `validateOperationOptions()` — now it sits above the
unrelated `parseStartTime()` and becomes an orphan (the next `/** */` block
overrides it for `parseStartTime`, and `validateOperationOptions` loses its
Javadoc).
Moving `parseStartTime()` + `getStartTime()` to *after*
`validateOperationOptions()` would keep the existing Javadoc attached to the
method it documents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
