allthingssecurity commented on PR #26942:
URL: https://github.com/apache/camel/pull/26942#issuecomment-5952533418
@gnodet friendly ping, in case this got lost: did you have a chance to look
at it?
To make the decision easy, either way is fine with us:
- **Keep the fix.** Up to 4.20 `headers.keySet().remove("x-trace")` also
removed `X-Trace`; since 4.21 it silently removes nothing (the map overrides
`entrySet()` but not `keySet()`). The PR restores that with the existing
`findIndex`/`removeByIndex` path, and the 4.23 upgrade guide covers the one
visible change (`retainAll`).
- **Don't support it**, as @davsclaus suggested: then I'd close this PR and
CAMEL-25059 as Won't Fix. If useful, I can instead open a small PR that adds a
sentence to the `Message.getHeaders()` Javadoc saying headers should be
modified through the Camel API (`setHeader`, `removeHeader`, `removeHeaders`),
not through the map's key set view.
Just let me know which you prefer.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
