davsclaus commented on code in PR #27293:
URL: https://github.com/apache/camel/pull/27293#discussion_r4167566002
##########
dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/KnownDependenciesResolver.java:
##########
@@ -40,15 +44,17 @@ public KnownDependenciesResolver(CamelContext camelContext,
String springBootVer
}
public void loadKnownDependencies() {
- doLoadKnownDependencies("camel-main-known-dependencies.properties");
-
doLoadKnownDependencies("camel-component-known-dependencies.properties");
+ doLoadKnownDependencies("camel-main-known-dependencies.properties",
false);
+
doLoadKnownDependencies("camel-component-known-dependencies.properties", true);
+ // third-party libraries mapped by package, generated from
src/main/known-third-party-libraries.properties
+
doLoadKnownDependencies("camel-thirdparty-known-dependencies.properties",
false);
Review Comment:
This load (and the comment above it) comes from CAMEL-24809, not from
#27283. On `camel-4.22.x` nothing generates
`camel-thirdparty-known-dependencies.properties` (`PrepareKameletMainMojo` has
no support for it here), so this is a no-op. It should be dropped from the
backport.
##########
dsl/camel-kamelet-main/src/test/java/org/apache/camel/main/download/KnownDependenciesResolverTest.java:
##########
@@ -53,4 +55,80 @@ void mavenGavForClass_returnsPackageScopedDependency() {
public static class SomeClass {
}
+
+ @Test
+ void theShippedMappingResolvesThirdPartyClassesByPackage() {
Review Comment:
This test (and the `assertGav` helper further down) belongs to CAMEL-24809
and expects third-party mappings that don't exist on 4.22.x (e.g.
`org.eclipse.yasson`, `freemarker`, `io.joltcommunity`, `org.infinispan`, and
`org.postgresql.ds.PGSimpleDataSource`, since only `org.postgresql.Driver` is
mapped). It should fail here. Please keep only the tests added by #27283.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
