oscerd commented on PR #27195: URL: https://github.com/apache/camel/pull/27195#issuecomment-5978904272
CI is green on `c919f24998a3` — all seven checks pass, `mergeable=MERGEABLE`, `mergeStateStatus=CLEAN`. @davsclaus over to you. One correction to the automated re-review above, because it points a human reviewer away from the only part of this rebase that needed judgement. It says the regen commit *"touches only generated files"* — true — but also that *"all 4 substantive commits are byte-identical to the previously approved `cc05edd7`"*. They are not. `git range-diff` over the two ranges: ``` 1: 89d316829ef1 ! 1: 06e4cd247812 add the readTuples, readChanges and expand operations 2: 403350d880a0 = 2: 45c1626cb407 keep the validateOperationOptions javadoc with its method 3: 808b3526ee7a ! 3: 1ef803461e82 refuse a read filter part that resolved to nothing 4: cc05edd796f2 = 4: 4162023f8722 import the SDK Tuple in the read test ``` Two of the four changed, and the files involved include three non-generated ones: `openfga-component.adoc`, `OpenFgaAuthorizer.java` and `OpenFgaIT.java`. Commit 3's prose is the same text re-anchored, and its generated hunks moved into the regen commit. **Commit 1 carries real hand-merged content**, which is where a reviewer's attention is worth spending: - `OpenFgaAuthorizer.java` — three fields now where each branch had its own two/one; additive, mechanical. - `OpenFgaIT.java` — both test sets kept; additive, mechanical. - `openfga-component.adoc` — **not mechanical.** Both branches edited the same `What this component does not do yet` list and each struck its own entry. Keeping either side would have re-asserted a limitation that no longer exists, and silently: the page renders fine either way. I dropped both bullets and kept store/model management. So the thing I would actually check before merging is that one list, at `openfga-component.adoc`. Everything else in the rebase is either additive or regenerated. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
