davsclaus commented on code in PR #27201: URL: https://github.com/apache/camel/pull/27201#discussion_r4184404214
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc: ########## @@ -4178,6 +4178,21 @@ The `cancelCorrelationId` method of `org.apache.camel.component.jms.reply.ReplyM a `boolean`: `true` if the pending reply was cancelled, `false` if the request timeout or the reply had already taken it. A custom `ReplyManager` implementation has to change the return type. +=== camel-milo - potential breaking change + +Sampling interval behaviour changes for users who never set it. Review Comment: With the default now `1000.0` the effective sampling interval for users who never set it is unchanged, so this sentence (and "This restores the documented behaviour" at L4190 - the documented default actually changes from 0.0 to 1000.0) no longer holds. Please reword. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
