jamesnetherton commented on PR #27374: URL: https://github.com/apache/camel/pull/27374#issuecomment-5995646521
Thanks for the review @davsclaus. The upgrade guide section is moved in 7cad68d137f7, and the rest is addressed in 7abfb1393ca0. **`keyManagerMapper`** — removed. On Vert.x 4.5 `SSLHelper` only calls `keyManagerFactoryMapper`, and its default implementation was the only caller of `keyManagerMapper`; with `keyManagerFactoryMapper` overridden it was dead code on Vert.x 4, and the Vert.x 5 interface no longer has the method. **Per-name SSL context without key material** — no, on either version. When the trust manager mapper returns non-null for a server name, Vert.x 4 takes the per-name branch with `kmf == null`, and `SslContextProvider.createContext` falls back to the configured factory (`if (keyManagerFactory == null) keyManagerFactory = defaultKeyManagerFactory()`). Vert.x 5's `ServerSslContextProvider.createServerContext` has the same null check and fallback; it has to, because Vert.x 5's own `KeyManagerFactoryOptions` returns the same null mapper. `VertxWebsocketSSLTest.testServerNameIndication` covers exactly this path: SNI enabled on the server, trust managers and client auth configured, and a client forced to indicate a server name. **Remaining internal imports** — these all resolve on Vert.x 5 with identical descriptors, which is why the bytecode scan of the jars against the Vert.x 5 classpath never flagged them: `ConnectionBase.CLOSED_EXCEPTION`, `SocketAddressImpl` and `InboundBuffer` are still in the same packages in 5.1.8. `MimeMapping` in `camel-platform-http-main` is gone in Vert.x 5, but that module is not used by Camel Quarkus and is out of scope here. They are cleanup for the move of Camel itself to Vert.x 5 in 4.24 rather than runtime fixes. **`vertxFactory` test** — added `VertxFactoryTest`, which sets `Vertx.builder().with(...).withMetrics(...)` on the component and checks that the Vert.x instance is built by that builder. _Claude Code on behalf of @jamesnetherton_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
