allthingssecurity commented on PR #27389:
URL: https://github.com/apache/camel/pull/27389#issuecomment-6010338991
Thanks for the review. Addressed in 7ce41e783cd9 (the branch was rebased on
main first, to put the note under the existing camel-kafka heading, so the
first commit is now 98a7103f5e62):
- Upgrade guide: `==== A suspended consumer keeps its partitions` under the
camel-kafka section. A route started with its consumer suspended
(`keepOpen=true`) now joins the group and holds its partitions paused, where it
never connected before.
- `isRecoverable()`: it was a one-line change consistent with this PR, so I
made it. It now uses `isKafkaConsumerRunnableAndNotStopped()`, as the fetcher
thread of a suspended consumer keeps polling and reconnecting, and the unused
`isKafkaConsumerRunnable()` is removed. New
`testSuspendedConsumerIsRecoverable` fails without it (`expected: <true> but
was: <false>`) and passes with it. It only changes the health-check message of
a not-ready suspended consumer ("recovery in progress" instead of nothing).
camel-kafka: 225 unit tests pass (1 skipped); the integration tests need
Docker and were not run.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
