gnodet commented on code in PR #27216:
URL: https://github.com/apache/camel/pull/27216#discussion_r4192792888
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesRun.java:
##########
@@ -807,7 +807,7 @@ private Integer deployProject(String workingDir, boolean
reload) throws Exceptio
}
private void detectCluster() {
- if (!disableAuto) {
+ if (!disableAuto && clusterType == null) {
Review Comment:
Fixed in d29381cde87: restructured `detectCluster()` to apply per-cluster
defaults (minikube: `imageBuilder=docker`, `imagePush=false`; openshift:
`imageGroup=namespace`) based on the resolved cluster type, whether explicit or
auto-detected. The `--disable-auto` flag still suppresses both detection and
defaults. Added a test `explicitMinikubeClusterTypeShouldApplyDefaults`
asserting `imageBuilder=docker` for explicit `--cluster-type=minikube`, and a
sentence in the adoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
