allthingssecurity commented on PR #27466: URL: https://github.com/apache/camel/pull/27466#issuecomment-6033124383
Thanks @davsclaus. Added the note in 74e855cfb3da: `route-template.adoc` and the 4.23 upgrade guide now say that a `RouteTemplateContext` reused for several `addRouteFromTemplate` calls shares the template beans created for the first route, and that a new `RouteTemplateContext` per route gives new ones. About the red `build (17, false)` / `build (25, false)` checks: the three failures (`DumpModelAsYamlTransformRouteTest.testDumpModelAsYamlUriAsParameters`, `DumpModelAsYamlUriAsParametersTest.testDumpModelAsYaml` and `testDumpModelAsYamlGeneratedIds`) come from `main`, not from this PR: - CI tested the merge with `main` at 43fb0300bd10. The dump now writes the endpoint options sorted (`browseLimit, failFast, retainFirst`), while the expected YAML lists them in uri order (`failFast, retainFirst, browseLimit`). This PR does not touch the YAML dump. - The order comes from d7d5290793db (CAMEL-25381, #27449), merged after this branch was created. It changed `YamlModelWriterSupport` to write the options "as Camel builds them" (path options first, then sorted), but the expected files of these camel-core tests were not updated. - The same three tests fail on #27468, which only changes camel-util: https://github.com/apache/camel/actions/runs/37550176729/job/112671547779 - Locally on `origin/main` (fb86fbed28dc, without this PR), `-pl core/camel-core -am -Dtest='DumpModelAsYaml*'` gives the same 3 failures out of 10 tests. So nothing changes here for CI. The camel-core expected files (or the dump order) need a fix on `main`. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
