oscerd commented on PR #27477: URL: https://github.com/apache/camel/pull/27477#issuecomment-6034016855
Thanks for the thorough review, @davsclaus. Addressed in 4abae810a1d9: - **Output-format mismatch (blocking):** fixed — the submit-time format is stored on `AsyncTaskEntry` and used by both the consumer and `checkLocalAsyncTask`; new unit test covers the html-submitted / markdown-consumed case. (Replied inline.) - **Consumer scope & path segment:** the new NOTE says to run at most one consumer per component (a second competes for the same tasks), and clarifies that the path is still the required `operationId` but the consumer ignores the operation — it always drains the component's completed tasks. - **In-memory only:** the NOTE now states pending tasks live in an in-memory map visible only to the same `CamelContext`, are lost on restart, and that stopping the context cancels in-flight conversions. - **Minor — failure path runs the processor with the exception pre-set:** this is intentional. Setting the exception on the exchange and then routing it is what makes the *route's* `onException` handle the async failure (as `DoclingConsumerFailureTest` asserts). Calling the consumer's exception handler directly instead would bypass the route's error handling, which is the opposite of what we want here. Left as-is — happy to add an inline code comment if that reads clearer. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
