davsclaus opened a new pull request, #27487:
URL: https://github.com/apache/camel/pull/27487

   ## Description
   
   https://issues.apache.org/jira/browse/CAMEL-25411. This is a follow-up to 
#27486: the editor now checks the properties of a Kamelet, and with this change 
it also completes them.
   
   **The problem:** pressing Tab under `parameters:` of a `kamelet:` endpoint 
(or in its query) listed only the options of the kamelet component itself: 
`block`, `routeId`, `timeout`… The properties of the Kamelet, which are what 
goes there, were not offered.
   
   **Now the list shows, in order:**
   1. The properties of the Kamelet, required ones first, with their type, 
default and description. They are found with `KameletDefinitions.find`: the 
project's own Kamelet file in the directory of the route, else the catalog. A 
property that is already set is not offered again.
   2. A dim `── kamelet component options ──` divider that cannot be selected. 
Arrow keys skip it, and a click on it does nothing.
   3. The options of the kamelet component, which are for special uses.
   
   While filtering, the properties of the Kamelet stay above the divider. There 
is no divider when only one kind is listed, for example for a Kamelet without 
properties, or when a filter matches only one kind.
   
   ```
   ╭ kamelet options (9) ─────────────────────╮
   │ * tag                              string │
   │   prefix                           string │
   │── kamelet component options ─────────────│
   │   block                           boolean │
   │   ...                                     │
   │   routeId                          string │
   │   timeout                         integer │
   ```
   
   ## Tests
   
   `SourceKameletValidationTest`:
   - the properties of a project Kamelet come first;
   - a property that is already set is not listed;
   - a catalog Kamelet (`timer-source`) given in the query;
   - where the divider is, while filtering and without a filter;
   - no divider when a filter leaves one kind, and none for a Kamelet without 
properties.
   
   The camel-jbang-plugin-tui module: 1749 tests pass. Tried by hand in the 
source editor with the custom Kamelet from the benchmark.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to