gnodet commented on PR #27409:
URL: https://github.com/apache/camel/pull/27409#issuecomment-6037566358
All review concerns from @davsclaus and @oscerd have been addressed in the
two commits on this PR:
**Code fixes (commit `2496129c`):**
1. ✅ **Custom-pass prefix isolation** — each `custom=true` branch now guards
with its own prefix (`CAMEL_COMPONENT_`, `CAMEL_DATAFORMAT_`,
`CAMEL_LANGUAGE_`), so leftover keys from one category no longer bleed into
another
2. ✅ **camelCase name preservation** — catalog name lookup via `Map<String,
String>` (env-key → catalog-name); `longestMatch` returns the catalog name
directly, so `camel.dataformat.avroJackson`, `camel.language.exchangeProperty`,
etc. are produced without lowercasing
3. ✅ **Test options** — replaced non-existent options with real ones
(`avroJackson.auto-discover-object-mapper`, `avro.instance-class-name`,
`file-watch.queue-size`)
**Upgrade guide (commit `b5e646492f`):**
4. ✅ **Self-defeating workaround examples removed** — the guide now
correctly explains why `{{env:...}}` placeholders don't suppress direct
auto-binding, and documents the real remedies
5. ✅ **`autoConfigurationFailFast=false` scope** — corrected: only opt-out
is `camel.main.autoConfigurationEnvironmentVariablesEnabled=false`
6. ✅ **Secrets concern** — documented: apps using `prod` profile with
component env vars need to rename vars or use vault
7. ✅ **`rest`/`rest-api` collision** — documented as a known limitation with
the `CAMEL_COMPONENT_REST_APIDOC=api.json` workaround
All inline review threads are resolved. CI is green. @oscerd, could you take
another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
