allthingssecurity commented on PR #27461: URL: https://github.com/apache/camel/pull/27461#issuecomment-6033129296
Thanks @davsclaus and @oscerd for the reviews. On the two notes: - `ConcurrentHashMap`: right, every access is under `managedEndpointsLock` except `managedEndpoints.clear()` in `doStop`, which runs outside the lock. I kept the concurrent map so that clear is safe without taking the lock in `doStop`. It is only used on endpoint add/remove, so the cost does not matter. I can switch to a `HashMap` and clear it under the lock if you prefer. - Owner entries: agreed. If the MBean is unregistered another way, the entry stays until `onEndpointRemove` of that endpoint or `doStop`, so it is bounded by the number of endpoint names. No change. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
