gnodet-bot commented on code in PR #27497:
URL: https://github.com/apache/camel/pull/27497#discussion_r4206863891
##########
core/camel-util/src/test/java/org/apache/camel/util/SecurityUtilsTest.java:
##########
@@ -54,6 +54,8 @@ void testHostnameVerificationOptionsAreRegistered() {
// camel.main.profile=prod cannot refuse it (CAMEL-25409)
assertTrue(SecurityUtils.isInsecureValue("camel.component.mongodb.tlsAllowInvalidHostnames",
true));
assertFalse(SecurityUtils.isInsecureValue("camel.component.mongodb.tlsAllowInvalidHostnames",
false));
+ assertTrue(SecurityUtils.isInsecureValue(
+
"camel.component.debezium-mongodb.mongodbSslInvalidHostnameAllowed", true));
assertTrue(SecurityUtils.isInsecureValue("camel.component.netty-http.hostnameVerification",
false));
Review Comment:
💡 **Nit:** Consider adding the `assertFalse` boundary assertion to match the
pattern used for `mongodb.tlsAllowInvalidHostnames`. Currently
`netty-http.hostnameVerification` and `splunk-hec.skipTlsVerify` also lack
their `assertFalse` counterpart, so the new entry is consistent with 2 of 3
existing entries — but completing all of them would strengthen the test suite.
```suggestion
assertTrue(SecurityUtils.isInsecureValue(
"camel.component.debezium-mongodb.mongodbSslInvalidHostnameAllowed", true));
assertFalse(SecurityUtils.isInsecureValue(
"camel.component.debezium-mongodb.mongodbSslInvalidHostnameAllowed", false));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
