gnodet commented on PR #26845:
URL: https://github.com/apache/camel/pull/26845#issuecomment-6040749220
Addressing oscerd's review:
**1. InterceptSendToEndpoint unwrap** — Fixed in the new commit:
`evictComponentDataSources()` now unwraps `InterceptSendToEndpoint` proxies to
the original endpoint before applying the component check and DataSource
extractor, so intercepted endpoints (`interceptSendToEndpoint("jdbc:*")`) are
no longer silently skipped.
**2. Component re-created on reload** — This is an inherent ordering
constraint in `DefaultContextReloadStrategy`: `reloadComponentProperties()`
(which may replace the component) runs before `notifySecretRotation()`, so the
new instance has no prior endpoint references yet. The workaround of matching
by component type rather than identity would collect endpoints from *all*
components of that type (e.g. both a primary and a secondary `JdbcComponent` in
the same context), which risks over-eviction. For now this limitation is
documented in the adoc — the common case (no placeholder-valued
`camel.component.jdbc.*` options) is unaffected since the component is not
replaced.
**3. sql-stored** — Added `SecretRotationAware` to `SqlStoredComponent` in
the new commit.
**4. java.sql.Wrapper support** — Fixed in the new commit:
`evictDataSourceConnections()` now calls
`isWrapperFor`/`unwrap(DataSource.class)` before applying pool-specific
detection, so Spring proxy wrappers (TransactionAwareDataSourceProxy,
LazyConnectionDataSourceProxy) are unwrapped to the underlying pool.
**5. Docs: eviction on every reload** — Added a NOTE to both
jdbc-component.adoc and sql-component.adoc clarifying that eviction fires on
any context reload, not only vault secret rotation events.
**6. HikariCredentialsProvider version** — Updated to
`HikariCredentialsProvider (HikariCP 7.0 or later)` in all four doc copies and
the DataSourceHelper Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
