gnodet-bot commented on code in PR #27514: URL: https://github.com/apache/camel/pull/27514#discussion_r4211777373
########## dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/LaunchManagerInfraTest.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.dsl.jbang.core.commands.tui; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.camel.util.json.JsonObject; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * The infra services an example needs may name the implementation too ({@code aws sqs}): it is started with both, and + * known as running by the service alone, as {@code camel infra run aws sqs} runs as {@code aws}. + */ +class LaunchManagerInfraTest { + + private final List<InfraInfo> running = new ArrayList<>(); + private final LaunchManager lm = new LaunchManager(() -> running); + + @Test + void theServiceOfAnEntryWithItsImplementation() { + assertThat(LaunchManager.serviceOf("aws sqs")).isEqualTo("aws"); + assertThat(LaunchManager.serviceOf("kafka")).isEqualTo("kafka"); + } + + @Test + void aServiceWithItsImplementationIsMissingUntilItsServiceRuns() { + JsonObject example = new JsonObject(); + example.put("infraServices", List.of("aws sqs", "kafka")); + + assertThat(lm.findMissingInfraServices(example)).containsExactly("aws sqs", "kafka"); + + running.add(infra("aws")); + assertThat(lm.findMissingInfraServices(example)).containsExactly("kafka"); + } + + private static InfraInfo infra(String alias) { + InfraInfo info = new InfraInfo(); + info.alias = alias; + info.alive = true; + return info; + } +} Review Comment: 💡 **Missing test for `checkDeferredLaunch`** (raised in prior review — still unaddressed) The same `serviceOf` mapping was applied in `checkDeferredLaunch` at `LaunchManager.java:357`, but this test class only covers `findMissingInfraServices` and `serviceOf` directly. There is no test that: - Sets up a deferred launch requiring `"aws sqs"` - Marks `"aws"` as alive (simulating infra becoming live) - Asserts the deferred action fires A regression in the `checkDeferredLaunch` path would not be caught by any of the existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
