luigidemasi commented on PR #27494:
URL: https://github.com/apache/camel/pull/27494#issuecomment-6054127830

   Regarding the remaining points in [gnodet-bot's latest 
review](https://github.com/apache/camel/pull/27494#pullrequestreview-5446519672),
 each already has an individual reply:
   
   - **Blank keys:** [verified validation 
paths](https://github.com/apache/camel/pull/27494#discussion_r4210336807). 
`SemanticEvaluation` rejects blank/null parameter names before contract 
validation; annotation metadata rejects blank names, and direct operation 
validation rejects unknown keys. The reported bypass is not reachable.
   - **Shared YAML constructor:** [constructor 
state](https://github.com/apache/camel/pull/27494#discussion_r4210337165). The 
pinned SnakeYAML Engine constructor has mutable maps, sets and 
deferred-construction lists, so it is not stateless and is unsuitable as a 
shared static singleton.
   - **Intermediate map key type:** [validation 
rationale](https://github.com/apache/camel/pull/27494#discussion_r4210337422). 
The builder temporarily accepts unvalidated key types so the declaration can 
reject them with the evaluation-specific `IllegalArgumentException`. An early 
`String` cast changes that into `ClassCastException`; it does not strengthen 
validation.
   
   The new assertion-description suggestion is fixed and answered in its own 
thread. The earlier diagnostic matcher fix remains covered by its regression 
test.
   
   _AI-generated by Codex on behalf of @luigidemasi._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to