oscerd opened a new pull request, #27550:
URL: https://github.com/apache/camel/pull/27550

   ## What
   
   `camel_eval_expression` was classified read-only, so the Camel TUI's ACP 
permission handler and the `camel mcp` server's `readOnlyHint` auto-approved it 
without prompting. Because it evaluates an expression in any language 
(downloading the language's component on demand), it should behave like the 
other non-read-only authoring tools and be put in front of the user, 
consistently across both MCP entry points.
   
   ## Changes
   
   - `AuthoringTools` (camel-jbang-core): mark `camel_eval_expression` 
`readOnly(false)`.
   - `camel mcp` wrapper (`mcp/AuthoringTools`): flip the `@Tool` 
`readOnlyHint` to `false` to match.
   - `TuiToolRegistry`: update the Javadoc that described eval as read-only.
   - Tests updated to the new classification: core `AuthoringToolsTest`, 
`TuiToolRegistryEvalExpressionTest`, and `AiPanelAcpTest` (eval now prompts 
instead of being auto-approved).
   
   Resolves CAMEL-25443.
   
   ## Testing
   
   Verified the affected jbang modules' tests locally (camel-jbang-core, 
camel-jbang-mcp, camel-jbang-plugin-tui): `AuthoringToolsTest` (core 14, mcp 
9), `TuiToolRegistryEvalExpressionTest`, `TuiToolRegistryCoreToolsTest`, 
`AiPanelAcpTest` (49), `AiPanelTest` (80) — all green. The full reactor build 
runs in CI.
   
   _Claude Code on behalf of oscerd_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to