davsclaus commented on code in PR #27524:
URL: https://github.com/apache/camel/pull/27524#discussion_r4216654259
##########
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultRoutesLoader.java:
##########
@@ -292,6 +297,16 @@ public Set<String> updateRoutes(Collection<Resource>
resources) throws Exception
return answer;
}
+ updateLock.lockInterruptibly();
Review Comment:
Nit: worth a short comment that the lock is held while the replaced routes
are stopped, so an `updateRoutes` call from an exchange of a route being
replaced by another call waits here until the shutdown timeout (the case in the
upgrade guide). It makes the trade-off visible to the next reader of this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
