allthingssecurity commented on code in PR #27525:
URL: https://github.com/apache/camel/pull/27525#discussion_r4216855454
##########
components/camel-python3/src/main/java/org/apache/camel/language/python3/Python3Expression.java:
##########
@@ -33,6 +36,7 @@ public Python3Expression(String text) {
Python3Expression(String text, Python3Language language) {
this.text = text;
+ this.bindVariables = text != null && text.contains("variables");
Review Comment:
Good idea. To make sure I do the right thing, the plan would be to align
JavaScript, Python and Python3 on the names
`ExchangeHelper.populateVariableMap` gives Groovy:
- add `camelContext`, `request`/`in`, `header`/`headers`,
`exchangeProperty`/`exchangeProperties`, `variable`/`variables`
(`response`/`out` and `exception` too, where the language has them)
- keep the current `context`, `message` and `properties` as deprecated
aliases, documented as such, with an upgrade guide note
- python3 in its default data-only mode would get only the data names
(`header(s)`, `exchangeProperty`/`exchangeProperties`, `variable(s)`, `body`),
not `exchange`/`camelContext`/`request`, so its sandbox stays as it is
As it touches three languages and adds deprecations, would you prefer it as
a separate JIRA right after this PR, or in this PR?
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
