squakez commented on code in PR #6873:
URL: https://github.com/apache/camel-k/pull/6873#discussion_r4219665106
##########
pkg/builder/git.go:
##########
@@ -75,7 +75,7 @@ func cloneProject(ctx *builderContext) error {
if ctx.Build.Git.Path != "" {
gitClonePath = filepath.Join(ctx.Path, "repo")
}
- if _, err := util.CloneGitProject(*ctx.Build.Git, gitClonePath,
secretToken); err != nil {
+ if _, err := util.CloneGitProject(*ctx.Build.Git, gitClonePath,
util.DefaultGitUsername, secretToken); err != nil {
Review Comment:
I think we need to include the `.spec.git.username` field in the Integration
as well in order to make full parity between git feature and gitops. Feel free
to either include as a new commit in this PR or open a new follow up issue to
make this development afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
