gnodet-bot commented on code in PR #27552:
URL: https://github.com/apache/camel/pull/27552#discussion_r4219883860


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -4856,3 +4856,15 @@ The `kubernetes-configmaps` developer console now 
reports the config map names a
 `camel.vault.kubernetescm` instead of reading the Kubernetes secrets vault 
configuration.
 Its text output labels the list `Config maps in use:` instead of `Secrets in 
use:`.
 Both Kubernetes vault consoles return empty lists when no resource names are 
configured.
+
+=== camel-datasonnet - DataWeave auto-conversion now fails fast on unsupported 
constructs

Review Comment:
   💡 **Minor doc gap:** This section covers the fail-fast behaviour for 
*unsupported constructs* (i.e. `DataWeaveConversionException` thrown by the 
converter), but the PR also changes the parser itself — 
`DataWeaveParser.expect()` now throws `DataWeaveConversionException` for 
*syntactically malformed* input (e.g. a missing `}`), whereas previously it 
silently produced a garbled/partial AST that could result in strange runtime 
behaviour.
   
   Consider extending this entry (or adding a note) to mention that 
syntactically invalid DataWeave scripts will also now throw at startup, not 
just scripts with unsupported semantic constructs. Users migrating from an 
environment where malformed scripts were silently tolerated will benefit from 
knowing this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to