allthingssecurity commented on PR #27588:
URL: https://github.com/apache/camel/pull/27588#issuecomment-6077680550

   Thanks @oscerd. Addressed in a048d0b:
   
   - **[Suggestion] mocked `ViewRow` stubs `valueAs(Object.class)` only** — 
done as a comment in the `viewRow(...)` helper. It pins the 
`valueAs(Class)`/`keyAs(Class)` overloads that `CouchbaseConsumer` calls, and 
says that a move to `valueAs(TypeRef)` must be stubbed there too, since an 
unstubbed call returns `null` and fails as an NPE, not as a clear assertion. 
Test-only change.
   - **[Question] not clearing the in-flight set in `doStart`/`doStop`** — no 
change, as explained in the PR description; that ack is for @davsclaus.
   
   Tests: camel-couchbase `install`, 61 unit tests, 0 failures (ITs skipped 
without a container).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to