allthingssecurity commented on PR #27593: URL: https://github.com/apache/camel/pull/27593#issuecomment-6077692495
@oscerd thanks for the review and the approval. Taking your findings in order: 1. Daemon caller thread: done in 1f50eb5a7e2d. I applied your suggestion, and the test now also interrupts and joins `wasm-caller` in a `finally`, so the spinning guest is stopped even when an assertion fails. 2. `isRunningGuestCode`: done in 1f50eb5a7e2d. It now matches the `run.endive.` package prefix instead of `InterpreterMachine`. 3. `createInstance()`: done in 1f50eb5a7e2d. It builds the instance and its three exports into locals and assigns all four fields at the end. 4. `close()`: done in 1f50eb5a7e2d. Endive 1.1.0's `Instance` implements `AutoCloseable` and has `close()` (checked with `javap`; it delegates to `Machine.close()`). `discardInstance()` now calls it, and adds anything it throws as suppressed to the original exception. `WasmFunction.close()` closes the current instance under the lock. Nothing called `WasmFunction.close()` before, so `WasmProducer.doStop()` now calls it too. 5. Perf on a high-error-rate route: added one sentence to "Errors and module state" on both the component and language pages (catalog copies mirrored). It says that on a route where every call traps, the module is instantiated again for every message (data segments copied, start function run). 6. Upgrade guide: still committed to that. Whichever of this PR and #27592 merges second, I will put the two camel-wasm notes together. camel-wasm: 9 tests, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
