davsclaus commented on code in PR #27562: URL: https://github.com/apache/camel/pull/27562#discussion_r4227345269
########## components/camel-pqc/src/main/docs/pqc-component.adoc: ########## @@ -93,15 +93,15 @@ BouncyCastle constants (`ml_dsa_87`) is accepted as an alias of the canonical na | `MLKEM` | `ML-KEM-512` (default), `ML-KEM-768`, `ML-KEM-1024` | `SLHDSA` | `SLH-DSA-SHA2-128S`, `SLH-DSA-SHAKE-256F`, ... (see `SLHDSAParameterSpec`) | `FALCON` | `FALCON-512`, `FALCON-1024` -| `DILITHIUM` | `ML-DSA-44`, `ML-DSA-65`, `ML-DSA-87` (default) +| `DILITHIUM` | `ML-DSA-44` (lifecycle manager default), `ML-DSA-65`, `ML-DSA-87` (component default) Review Comment: Now that DILITHIUM and CMCE tell the two defaults apart, the plain `(default)` on the MLDSA, MLKEM and KYBER rows reads as if it applied to the lifecycle managers too, but those defaults differ as well (`KeyAlgorithmSupport` and the AWS/Vault managers vs the `PQCDefault*Material` classes): MLDSA `ML-DSA-44` vs `ML-DSA-65`, MLKEM `ML-KEM-768` vs `ML-KEM-512`, KYBER `ML-KEM-768` vs `ML-KEM-1024`. Maybe annotate them the same way (and the catalog copy with it). This also applies to the 4.22.x docs, so it's fine as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
