oscerd commented on PR #27507: URL: https://github.com/apache/camel/pull/27507#issuecomment-6077822112
Thanks for the review — all four points are in, pushed as `2a9e482` on top of a rebase onto `main`. **1. `engineReady` never cleared** (inline) — overrode `pollingStopped()`. Replied in the thread with the `javap` check on the `ConnectorCallback` contract and proof the new assertion fails without the change. **2. Test coverage of the real wiring** — added `theAutoCreatedHealthCheckReportsTheInitialStateUntilPolling`, which uses the check the consumer builds for itself and never calls `setHealthCheck`. It asserts the type, the id (`consumer:readiness`), that it reports the registry initial state while the task is held in startup, and that it flips to `UP` once polling begins. Worth noting what this surfaced: `getHealthCheck()` is `null` until the consumer is started, because `doBuild()` runs as part of the consumer's start lifecycle and the route is `autoStartup(false)`. So the assertion has to come after `consumer.start()` — which is precisely the ordering the old test was papering over by constructing the check by hand. **3. Nit — grouped resets** — `engineReady`, `engineFailure` and `engineStopped` are now reset together before `super.doStart()`. **4. Nit — temp dir** — the test now writes to `target/data`, matching `DebeziumConsumerEngineFailureTest`. **Rebase:** the branch was 106 commits behind and the upgrade guide conflicted. While resolving it I noticed my entry had been appended at the end of the file, which puts it *under* the `== Route reload` level-2 section rather than in the 4.23 component list — the same placement problem you flagged on #27503. Moved it next to `=== camel-debezium - a failed embedded engine is now reported`, the CAMEL-24889 entry it follows on from. **Verification:** `camel-debezium-common` is green — 22 tests, 0 failures. Not resolving the conversation, leaving that to you. _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
