allthingssecurity commented on PR #27595:
URL: https://github.com/apache/camel/pull/27595#issuecomment-6077660841
@oscerd thanks for the review. Taking your findings in order:
1. `defaultValue` on `@Metadata`: done in c2813718c258.
`collectionSourceType` (from `main`) actually carried it on both annotations
too, so I dropped the `@Metadata` copy from both and kept the `@UriParam` one.
After regenerating, the generated JSON (and so the catalog) is unchanged:
`"defaultValue": "auto"` for both options.
2. Validation in `doInit()`: done in c2813718c258. The endpoint now
validates the value when it is initialized, so a route with a typo fails at
context start, before the collection is loaded.
`shouldRejectAnUnknownResolveVariablesFromPropertiesValue` now expects
`context.getEndpoint(uri)` to fail and checks that the collection was not
fetched.
3. JIRA: CAMEL-25483's description already describes the
`auto`/`enabled`/`disabled` option. I left the first commit message alone to
avoid a force-push; the squash-merge message can use the final shape.
4. `{{` message: done in c2813718c258. It now says: "Define the variable in
the collection, or supply it with the variables option
(variable.<name>=<value>). A literal {{ that is not a variable is not supported
in these parts of a request." It does not name `resolveVariablesFromProperties`
as an escape hatch, because that option does not bypass the check.
`buildDelegateUri` checks for `{{` whatever the option is set to; `enabled`
only lets a Camel property with that plain name fill the value, and a literal
`{{` still fails. A test asserts the new text.
camel-rest-postman: 197 tests, 0 failures. The new commit should also get CI
running on the head again.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
