luigidemasi commented on code in PR #27602:
URL: https://github.com/apache/camel/pull/27602#discussion_r4232860278
##########
dsl/camel-cli-connector/src/main/java/org/apache/camel/cli/connector/LocalCliConnector.java:
##########
@@ -1841,6 +1925,13 @@ private JsonObject collectVaults() {
@Override
protected void doStop() throws Exception {
ServiceHelper.stopService(transport);
+ // Stop the transport before taking this monitor: file dispatch may
hold it while the transport stops.
+ synchronized (this) {
+ if (semanticExecutor != null) {
+ semanticExecutor.shutdownNow();
Review Comment:
Fixed in 28ec2fd5f1be at both sites. Shutdown now goes through Camel's
`ExecutorServiceManager`, which removes the tracked pool and notifies lifecycle
management.
Extended the connector shutdown-race and console stop/restart tests to
verify removal callbacks while the context is still running. Both fail with the
previous direct calls and pass with the fix. All 314 semantic/connector tests
passed without retries; the full 704-module root build passed with tests
skipped (5m 40s).
_OpenAI Codex on behalf of @luigidemasi, via /oss-address-review._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
