luigidemasi commented on PR #27649: URL: https://github.com/apache/camel/pull/27649#issuecomment-6096095189
Response to the six broader points in [this review](https://github.com/apache/camel/pull/27649#pullrequestreview-5478167967), addressed at `fa99d7d1407991cf4c2e0bafbf9ce1e6f146a1aa`: 1. **Design and scope:** added a [concrete design proposal](https://github.com/apache/camel/blob/fa99d7d1407991cf4c2e0bafbf9ce1e6f146a1aa/design/semantic-audit.adoc) covering configuration, decisions, lifecycle and delivery. DSL-first was selected for this implementation; properties remain a valid alternative, and no prior upstream acceptance is claimed. The memory backend supplies the recent-history role proposed by CAMEL-25357, so it should not gain a competing recorder. Runtime/SPI, connector, TUI and CLI remain separate layers and commits; runtime capture has no presentation dependency. I have kept the complete proposal in this PR for end-to-end review rather than creating additional PRs or claiming the design question is already approved. 2. **Selective capture and decisions:** explicit decisions are now retained whenever the global default or any expert override enables capture. Expert exclusions continue to govern evaluations. This preserves the global-off/security-on use case without choosing an arbitrary evidence owner; the effective decision setting is exposed as `decisionsEnabled` and covered by regressions. 3. **API boundary:** moved the dispatcher, invocation handles, request identity and transport plumbing to `org.apache.camel.semantic.internal.SemanticAuditService`. The route-facing `SemanticAudit` facade retains explicit decisions and the documented evidence property. The cross-package console bridge is documented as internal; application callers use the existing two-argument evaluation API. 4. **Record/query contract:** retained versioned map serialization, strengthened field and nested-result type validation, and added typed timestamp, duration and evidence accessors. `SemanticAuditQuery.matches` is public and documents exact case-sensitive AND filters and inclusive time matching. Persisted-record validation and field-order tests cover the boundary. 5. **Query contention:** memory queries copy a consistent snapshot under the lock and filter outside it. Immutable records cache the parsed timestamp, so repeated queries do not parse every timestamp while blocking delivery. 6. **Observer order:** corrected the contract to reverse start-callback order. Registry registration order is not promised; no additional ordering mechanism was introduced. The hosted YAML schema regression is also fixed: declarations require evaluation, audit, or both. All 222 validator tests pass. The requested `camel semantic audit` CLI retrieval is included, using the same reader, filters, cursors and evidence lookup. _AI-generated by OpenAI Codex on behalf of @luigidemasi via /oss-address-review._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
