allthingssecurity commented on PR #27672: URL: https://github.com/apache/camel/pull/27672#issuecomment-6106217108
Both inline nits are applied in 79d32739480b (see the inline replies). On the unclosed `ResponseInputStream` when `createExchanges` throws: I checked both paths. The listing path already closes it: the stream is added to `s3Objects` before `createExchange` is called (`AWS2S3Consumer.java:286-287`) and the catch closes every stream in that list (line 301). The `fileName` path (`poll()`, line 134) does not: there the key is removed but the stream stays open if `IoUtils.toByteArray` fails. I left that one out of this PR, as it is existing behaviour on an I/O failure in the middle of a download and I have no clean way to test it with the fake server; I can add it here or in a follow-up if you prefer. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
