allthingssecurity commented on PR #27697:
URL: https://github.com/apache/camel/pull/27697#issuecomment-6120109946
1. Agreed, #27698 first. The two `releaseExchange(exchange, true)` calls for
exchanges that are never routed are the
ones main already has; no change here. The new call in `createExchange`
uses `done()` for a pooled exchange, which
puts it into the pool once with and without #27698, so I left it.
2. Done in d676411892a9 (inline reply).
3. Not intended. d676411892a9 adds a rule: when the listing returned
objects, at least one get failed with something
other than `NoSuchKeyException`, and S3 answered the get of none of the
listed objects, the poll fails with the
failure of the first object (all keys are removed from the in-progress
repository first, and the failures are not
reported per object as well). So expired credentials, a missing
`s3:GetObject` permission or throttling between
the listing and the gets are failed polls and count for
`backoffErrorThreshold`; one object that cannot be read
among others that can is skipped as before. I did not classify by status
code, because the same code can be about
one object or about everything. Consequences, also in the PR description:
a bucket that holds only unreadable
objects fails every poll, and every listed object of the poll is tried
before it fails. Test:
`pollFailsWhenNoneOfTheListedObjectsCouldBeGot` (both gets refused:
`poll()` throws the `S3Exception`, no key is
left in progress, the next poll consumes both once the gets are allowed);
it fails on the previous commit.
If you prefer another rule, I will change it.
4. main is still 4.23.0-SNAPSHOT and has no
`camel-4x-upgrade-guide-4_24.adoc` yet (checked on origin/main today),
so the note is still in the 4_23 guide. I will move it to the 4_24 guide
as soon as that file exists; it can stay
where it is if the fix goes to `camel-4.23.x` as well.
5. The PR description no longer calls CAMEL-25558 a placeholder.
camel-aws2-s3 after the commit: 104 tests, 0 failures.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
