gnodet-bot commented on code in PR #27714:
URL: https://github.com/apache/camel/pull/27714#discussion_r4248498975
##########
core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedEventNotifier.java:
##########
@@ -168,8 +168,8 @@ public MBeanNotificationInfo[] getNotificationInfo() {
// JmxNotificationEventNotifier uses the simple class name of the
event as the notification type
List<MBeanNotificationInfo> infos = new ArrayList<>();
for (CamelEvent.Type type : CamelEvent.Type.values()) {
- if (type == CamelEvent.Type.Custom) {
- // custom events have their own class names
+ if (type == CamelEvent.Type.Custom || type == CamelEvent.Type.Ai) {
Review Comment:
💡 **`ManagedEventNotifierMBean` is missing
`isIgnoreAiEvents`/`setIgnoreAiEvents`**
`ManagedEventNotifier` correctly skips `Type.Ai` in `getNotificationInfo()`
here, but `ManagedEventNotifierMBean` (the JMX interface) was not updated: it
still ends at `setIgnoreStepEvents(boolean)` without declaring the new
`ignoreAiEvents` attribute. JMX introspection exposes only what the MBean
interface declares, so the attribute won't be visible or settable via
JConsole/Hawtio — unlike every other `ignore*` flag which IS declared in that
interface.
```suggestion
if (type == CamelEvent.Type.Custom || type ==
CamelEvent.Type.Ai) {
```
Fix: add to `ManagedEventNotifierMBean`:
```java
boolean isIgnoreAiEvents();
void setIgnoreAiEvents(boolean ignoreAiEvents);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
