mionker commented on PR #27173: URL: https://github.com/apache/camel/pull/27173#issuecomment-6128545650
I have addressed all issues except the test for the ExceptionHandler path. I have posed a few questions regarding the BatchConsumerWorker onBatch exception handler in comparison to the existing standard consumer. I also noted that I do not think the differentiation between a JMSExceptions and other Eexceptions is necessary since SJMSHelper.rollbackIfNeeded will only throw JMSExceptions and therefore its signature can be changed. Finally, I was not sure how to test it, since I did not find an existing test for the regular SJMS consumer. After further research, I did find a comparable test of the camel-jms component, which I can hopefully use as a basis. BTW, I think I identified a few differences between the JMS and the SJMS components in terms of the final commit or rollback and the handling of exceptions, that I think can be harmonized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
