davsclaus commented on code in PR #27597:
URL: https://github.com/apache/camel/pull/27597#discussion_r4251268581
##########
test-infra/camel-test-infra-ibmmq/src/main/java/org/apache/camel/test/infra/ibmmq/services/IbmMQLocalContainerInfraService.java:
##########
@@ -74,10 +75,14 @@ public IbmMQContainer() {
// AND the listener-port and log-message checks; a
plain chained waitingFor() would replace,
// not combine, the strategies.
WITH_INDIVIDUAL_TIMEOUTS_ONLY keeps each strategy's own timeout
// instead of the 30s outer cap the default
WaitAllStrategy mode would impose.
+ // Note: withStartupTimeout() must be called on each
strategy individually when using
+ // WITH_INDIVIDUAL_TIMEOUTS_ONLY mode; calling it on
the WaitAllStrategy itself would
+ // throw an IllegalStateException.
Review Comment:
Good comment, it explains the `IllegalStateException` from the first commit.
The PR description should be updated the same way: it still says the timeout is
added to the `WaitAllStrategy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
