apupier opened a new pull request, #27823: URL: https://github.com/apache/camel/pull/27823
When PrepareCamelJBangCommandsMojo scans the commands directory it walks all .java files, including interfaces (e.g. BindingProvider, TemplateProvider, Update, MavenResolverMixinSpec, QuarkusPlatformMixinSpec). Three places in parseOptionsFromClassHierarchy and resolveCompletionCandidates performed an unchecked cast of Roaster.parse() result to JavaClassSource. When Roaster returns a JavaInterfaceImpl for an interface file the cast threw a ClassCastException that was caught by the outer try/catch and logged as a WARNING. Fix: replace each unchecked cast with an instanceof pattern-match guard. Non-class types (interfaces, enums, annotations) are now silently skipped at DEBUG level with an explanatory message instead of producing a WARNING. Affected call sites: - parent class file lookup in parseOptionsFromClassHierarchy - @Mixin field type file lookup in parseOptionsFromClassHierarchy - completionCandidates class file lookup in resolveCompletionCandidates A new test class PrepareCamelJBangCommandsMojoTest is added with two non-regression scenarios: - interface used as @Mixin type alongside a command class - interface file co-located with a concrete command class Co-authored-by: IBM Bob 2.2.1 # Description <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> # AI-assisted contributions - [ ] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
