oscerd commented on PR #27721:
URL: https://github.com/apache/camel/pull/27721#issuecomment-6163652654
Thanks both — the list-filter behaviour change is a fair catch, and the
latest push (`4ee0930`) addresses it.
Rather than wrapping every String value (which changed how `ListFilter`
dispatches them), a value is now wrapped as a literal snippet **only when
Chunk's own parser reports it contains tags** —
`Snippet.getSnippet(value).isSimple() == false`. Tag-free data stays a plain
`String`, so it still hits `listifyString()` and the string filters behave
exactly as before. Verified against chunk-templates 3.6.2:
- `{$body|slice(0:5)}` on `Hello World` → `Hello` (restored)
- `{$headers.name|get(0)}` on `Andrew` → `A`; `|join(-)` → `A-n-d-r-e-w`;
`|reverse` → `werdnA` (restored)
- `{$body}` on `{$headers.secret}` → printed literally (injection still
closed)
So the only behaviour change is for values that literally contain Chunk tags
— i.e. the markup that was previously being evaluated — which also keeps this
from being a broad default change in a patch line.
Tests added in `ChunkValueExpansionTest`: a `{$body|slice(0:5)}` filter test
on tag-free data, a nested **Map body** through the recursive path, and an
**exchange variable** carrying tags. Full `camel-chunk` suite (19) is green.
The upgrade-guide note now lives in `camel-4x-upgrade-guide-4_24.adoc` (this
ships in 4.24.0, since 4.23.0 is already tagged) and states that filters and
tag-free data are unaffected.
Re-requesting review.
_Claude Code on behalf of Andrea Cosentino (@oscerd)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
