gnodet commented on PR #27840: URL: https://github.com/apache/camel/pull/27840#issuecomment-6177239624
Thank you for the detailed review, @davsclaus! All findings have been addressed: 1. **`camel_error_diagnose` repeat tracking** — `recordSuccessfulAnswer` is called after a successful diagnose, and a test (`thirdIdenticalCallIsRepeated`) was added to `DiagnoseToolsTest`. 2. **Shared catalog dropped when `camelVersion` given** — `AuthoringTools.call` now sets the version on the context first (making it a no-op on the subsequent `setCatalog`), then loads the catalog from the service. 3. **TUI MCP server still counted failed calls** — `TuiMcpServer` now skips `recordSuccessfulAnswer` when the result starts with `"Error:"`. 4. **Design question (finding #4)** — The docs already say "A call that fails … does not count". The design is intentional: only truly deterministic failures (missing argument, unsupported extension) are covered; transient ones (network timeout on catalog download) benefit from the retry budget. 5. **`CatalogServiceTest` Quarkus version** — Test now uses `4.10.0` (not the built-in version) so the new code path is exercised. 6. **`CatalogService` assertion/NPE** — The misleading comment was replaced with an `IllegalStateException`. The NPE from `findQuarkusPlatformBom` returning null at both call sites (no-version and version-given Quarkus paths) is now fixed with a `ToolCallException` giving a readable message (9256f997ca1e). 7. **`Math.max(1, limit)`** — Both `KameletTools` and `CatalogTools` now use `limit > 0 ? limit : 50`. 8. **`KameletToolsTest` downloads from Maven Central** — Acknowledged. Making it offline with a loader hook is a refactoring beyond this fix scope; leaving as-is for now. 9. **`runtime` argument in `AuthoringTools`** — Removed; `loadCatalog` is called with `null` as the runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
