gnodet-bot commented on code in PR #27835:
URL: https://github.com/apache/camel/pull/27835#discussion_r4271833608
##########
core/camel-api/src/main/java/org/apache/camel/Route.java:
##########
@@ -380,16 +380,18 @@ default Resource getTemplatedRouteResource() {
/**
* Get the route type.
*
- * Important: is null after the route has been created.
- *
- * @return the route type during creation of the route, is null after the
route has been created.
+ * @return the route type, no longer null after the route has been created.
Review Comment:
💡 The updated `@return` text says "no longer null after the route has been
created" but the `@Nullable` annotation on the next line still signals that
`null` is a valid return value — these send contradictory signals to tooling
and callers.
Either soften the Javadoc to acknowledge that custom implementations may
still return `null`, or remove `@Nullable` (safe since `DefaultRoute` is the
only production implementation and no longer nulls this field).
```suggestion
* @return the route type; retained at runtime since 4.24.0 (was
previously cleared after startup).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
