davsclaus commented on code in PR #27849:
URL: https://github.com/apache/camel/pull/27849#discussion_r4279077912
##########
test-infra/camel-test-infra-docling/src/main/resources/org/apache/camel/test/infra/docling/services/container.properties:
##########
@@ -16,3 +16,4 @@
## ---------------------------------------------------------------------------
## Docling container configuration for test-infra
docling.container=quay.io/docling-project/docling-serve:v1.35.0
+docling.container.ppc64le=docling-serve:v1.35.0
Review Comment:
Without a registry, this resolves to
`docker.io/library/docling-serve:v1.35.0`, which does not exist. Upstream
quay.io publishes only amd64/arm64 for v1.35.0. The IBM ppc64le image exists,
and its config says ppc64le/linux (note: no `v` in the tag):
```suggestion
docling.container.ppc64le=icr.io/ppc64le-oss/docling-serve-ppc64le:1.35.0
```
##########
components/camel-ai/camel-docling/src/test/java/org/apache/camel/component/docling/integration/OcrExtractionIT.java:
##########
@@ -180,10 +180,6 @@ void testOcrWithMultipleTextBlocks() throws Exception {
.isTrue();
// Docling recognizes the footer but classifies it as page furniture,
which the default body export excludes.
- boolean foundFooter = resultLower.contains("footer");
- assertThat(foundFooter)
- .as("Footer text should be excluded from the default body
export. Got: %s", result)
- .isFalse();
Review Comment:
This assertion pins the documented CAMEL-23457 behaviour. If only the
ppc64le image differs, one option is to keep the check on the other
architectures:
```suggestion
// Docling recognizes the footer but classifies it as page
furniture, which the default body export excludes.
// The ppc64le image may classify it differently, so only verify
this on other architectures.
if (!"ppc64le".equals(System.getProperty("os.arch"))) {
assertThat(resultLower.contains("footer"))
.as("Footer text should be excluded from the default
body export. Got: %s", result)
.isFalse();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
