Croway commented on code in PR #27826:
URL: https://github.com/apache/camel/pull/27826#discussion_r4270706380
##########
dsl/camel-jbang/camel-launcher/src/main/resources/bin/camel.sh:
##########
@@ -100,9 +100,10 @@ then
REPO="$BASEDIR"
fi
-# Find the launcher JAR
+# Find the launcher JAR, excluding sources
LAUNCHER_JAR=
for f in "$BASEDIR"/camel-launcher-*.jar; do
+ case "$f" in *-sources.jar) continue ;; esac
Review Comment:
Implemented the suggested sources/javadoc filter, added javadoc regression
fixtures, and excluded both classifier archives from assembly content. Unix
tests and ZIP/TAR packaging checks pass.
_AI-generated by Codex on behalf of @Croway._
##########
dsl/camel-jbang/camel-launcher/src/main/resources/bin/camel.bat:
##########
@@ -49,9 +49,12 @@ set "JAVACMD=%CAMEL_JAVACMD%"
@REM Set JVM options if specified
if "%JAVA_OPTS%" == "" set JAVA_OPTS=-Xmx512m
-@REM Find the launcher JAR
+@REM Find the launcher JAR, excluding sources
set "LAUNCHER_JAR="
-for %%i in ("%BASEDIR%\camel-launcher-*.jar") do set "LAUNCHER_JAR=%%i"
+for %%i in ("%BASEDIR%\camel-launcher-*.jar") do (
+ echo %%~nxi| findstr /i /e /l /c:"-sources.jar" > nul
Review Comment:
Implemented the additional javadoc suffix filter and regression fixtures.
The Windows validator now runs CamelBatDiscoveryTest and FakeJavaTest; actual
Windows validation is pending the fresh CI run.
_AI-generated by Codex on behalf of @Croway._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
